vendor: Update json-iterator #6030
Conversation
gouthamve
changed the title
gouthamve
force-pushed
the
update-json-iterator
branch
2 times, most recently
from
c9bb021
to
50a34ce
Compare
gouthamve
changed the title
web/api/v1/api.go
Outdated
| stream.WriteFloat64(p.V) | ||
|
|
||
| // Taken from https://github.com/json-iterator/go/blob/master/stream_float.go#L71 as a workaround | ||
| // to https://github.com/json-it |
There was a problem hiding this comment.
Was this supposed to be a link to a GitHub issue? It looks truncated.
|
Could you elaborate on "Also add explicit support for NaN/Inf", how/where that's achieved? |
|
(just wondering because the last time I tried to update this json-iter, it resulted in NaN/Inf/-Inf causing marshaling errors, so I downgraded it again) |
|
Ah I guess that's just generally the manual |
Also add explicit support for NaN/Inf Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve
force-pushed
the
update-json-iterator
branch
from
50a34ce
to
f6c38aa
Compare
|
From my point of view it's to match prometheus/client_golang#570 However the jsoniter change was deliberate so the other choice would be to fork it? |
|
👍 |
| @@ -1266,10 +1266,23 @@ func marshalPointJSON(ptr unsafe.Pointer, stream *jsoniter.Stream) { | |||
| } | |||
| stream.WriteMore() | |||
| stream.WriteRaw(`"`) | |||
| stream.WriteFloat64(p.V) | |||
|
|
|||
| // Taken from https://github.com/json-iterator/go/blob/master/stream_float.go#L71 as a workaround | |||
There was a problem hiding this comment.
Is this tested properly in api_test.go?
There was a problem hiding this comment.
I find your lack of faith... disturbing:
prometheus/web/api/v1/api_test.go
Line 1705 in 76769d4
Also add explicit support for NaN/Inf
Signed-off-by: Goutham Veeramachaneni gouthamve@gmail.com