Bounded parallelism for DoParallelQueries #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah agree, no nice way to make it configurable - would need to be added to each StorageClient's config. LGTM |
|
Can't we make it flag configurable by making it a global variable? |
|
Maybe, where would the |
|
Yep, that's where it'll go :) Inspired by this piece in prometheus, which I DIDN'T like when I read it last week: |
bboreham
force-pushed
the
bounded-parallelism
branch
from
2c9e3e9
to
4195aea
Compare
Limit the number of queries we will send in parallel to the back-end, in case we have tens of thousands of series to fetch. Signed-off-by: Bryan Boreham <bryan@weave.works>
Signed-off-by: Bryan Boreham <bryan@weave.works>
bboreham
force-pushed
the
bounded-parallelism
branch
from
4195aea
to
bb8bcbf
Compare
|
Added a flag in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit the number of queries we will send in parallel to the back-end, in case we have tens of thousands of series to fetch.
In my tests, the DynamoDB back-end cannot be used with schema v9 without a change like this.
I couldn't see a nice way to make the "100" limit configurable. Suggestions welcome.