Khaines/improved redis options #1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ken Haines <khaines@microsoft.com>
Signed-off-by: Ken Haines <khaines@microsoft.com>
pracucci
reviewed
Dec 19, 2019
CHANGELOG.md
Outdated
| @@ -15,6 +15,7 @@ | |||
| * [FEATURE] The distributor can now drop labels from samples (similar to the removal of the replica label for HA ingestion) per user via the `distributor.drop-label` flag. #1726 | |||
| * [FEATURE] Added `global` ingestion rate limiter strategy. Deprecated `-distributor.limiter-reload-period` flag. #1766 | |||
| * [FEATURE] Added support for Microsoft Azure blob storage to be used for storing chunk data. #1913 | |||
| * [ENHANCEMENT] Added `password` and `enableTLS` options to redis cache configuration. Enables usage of Microsoft Azure Cache for Redis service. | |||
There was a problem hiding this comment.
good catch. corrected
pkg/chunk/cache/redis_cache.go
Outdated
| @@ -34,6 +36,8 @@ func (cfg *RedisConfig) RegisterFlagsWithPrefix(prefix, description string, f *f | |||
| f.DurationVar(&cfg.Expiration, prefix+"redis.expiration", 0, description+"How long keys stay in the redis.") | |||
| f.IntVar(&cfg.MaxIdleConns, prefix+"redis.max-idle-conns", 80, description+"Maximum number of idle connections in pool.") | |||
| f.IntVar(&cfg.MaxActiveConns, prefix+"redis.max-active-conns", 0, description+"Maximum number of active connections in pool.") | |||
| f.StringVar(&cfg.Password, prefix+"redis.password", "", "password to use when connecting to redis.") | |||
There was a problem hiding this comment.
Please add description+ to the help message and starts the help message with a capital letter, due to how the final message is composed.
Same feedback applies to the next CLI flag.
There was a problem hiding this comment.
Thanks @pracucci . Fixed this.
gouthamve
approved these changes
Jan 3, 2020
khaines
force-pushed
the
khaines/improved-redis-options
branch
from
81b8dae
to
566ba5d
Compare
Signed-off-by: Ken Haines <khaines@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: Enhancement to the redis cache package to support specifying a password and enabling TLS communication, via config. Enables the use of hosted Redis services such as Microsoft Azure Cache for Redis.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]