Upgrade Thanos to master #2634
Merged
Upgrade Thanos to master #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codesome
force-pushed
the
thanos-master
branch
3 times, most recently
from
95adb5f
to
5ab3b8e
Compare
pstibrany
approved these changes
May 27, 2020
pracucci
reviewed
May 27, 2020
|
A part from Prometheus changes, I've checked:
|
pracucci
reviewed
May 27, 2020
| @@ -255,16 +256,17 @@ func (a *API) RegisterQuerier(queryable storage.Queryable, engine *promql.Engine | |||
| api := v1.NewAPI( | |||
| engine, | |||
| queryable, | |||
| querier.DummyTargetRetriever{}, | |||
| querier.DummyAlertmanagerRetriever{}, | |||
| func(context.Context) v1.TargetRetriever { return &querier.DummyTargetRetriever{} }, | |||
There was a problem hiding this comment.
@gotjosh Once this PR is merged, you should be able to work on your metadata API refactoring.
There was a problem hiding this comment.
Thanks for the head's up, pretty excited to see this. We'll also be able to remove all the copy/paste for the alerts/rules API 😄
pracucci
reviewed
May 27, 2020
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Upgrades Thanos to master which has upgraded Prometheus
Some dependencies are giving errors and I am on it
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]