Add per-tenant S3 KMS SSE encryption key support to blocks storage #3811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
reviewed
Feb 10, 2021
pracucci
force-pushed
the
add-per-tenant-s3-kms-sse-encryption-key
branch
2 times, most recently
from
4418cfe
to
3aeec40
Compare
pstibrany
approved these changes
Feb 12, 2021
3 tasks
pracucci
force-pushed
the
add-per-tenant-s3-kms-sse-encryption-key
branch
2 times, most recently
from
14702f4
to
9261743
Compare
alvinlin123
reviewed
Feb 18, 2021
…nt basis. Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
add-per-tenant-s3-kms-sse-encryption-key
branch
from
0f038da
to
e31f09b
Compare
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pstibrany
approved these changes
Feb 22, 2021
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In the PR #3810 I'm proposing to add S3 KMS SSE encryption key support with a global config. On top of that, we'll need to also add support for a per-tenant encryption key override.
In this PR I'm proposing a refactoring to add the support in the blocks storage. The idea is to use
UserBucketClienteverywhere and take in inputoverrides. TheUserBucketClient.Upload()will read the per-tenant encryption key from overrides and then inject it when calling the parentUpload()(idea is to inject via context).I've manually tested it and looks working.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]