Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout for waiting on compactor to become ACTIVE in the ring. #4262

Merged
merged 17 commits into from
Jul 5, 2021
Merged

Add timeout for waiting on compactor to become ACTIVE in the ring. #4262

merged 17 commits into from
Jul 5, 2021

Conversation

ac1214
Copy link
Contributor

@ac1214 ac1214 commented Jun 4, 2021 •
edited
Loading

Signed-off-by: Albert ac1214@users.noreply.github.com

What this PR does:
Addresses #3914
Which issue(s) this PR fixes:
Fixes #3914

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@ac1214
add MaxRetries to WaitInstanceState
da68742 
Signed-off-by: Albert <ac1214@users.noreply.github.com>
ac1214 and others added 2 commits June 3, 2021 18:44
@ac1214
update CHANGELOG.md
f78aaea 
Signed-off-by: Albert <ac1214@users.noreply.github.com>
@ac1214
Merge branch 'master' into fix-3914
a4102f5
pracucci
pracucci reviewed Jun 4, 2021
View reviewed changes
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Given this PR tries to address #3914, I think a timeout is just fine. You can test a deadline on the context passed to ring.WaitInstanceState and that should be enough.

@ac1214
Add timeout for waiting on compactor to become ACTIVE in the ring.
70531df 
Signed-off-by: Albert <ac1214@users.noreply.github.com>
@ac1214
resolve merge conflict
d045a82 
Signed-off-by: Albert <ac1214@users.noreply.github.com>
@ac1214
add MaxRetries variable back to WaitInstanceState
46dc87b 
Signed-off-by: Albert <ac1214@users.noreply.github.com>
@ac1214 ac1214 changed the title add MaxRetries to WaitInstanceState Add timeout for waiting on compactor to become ACTIVE in the ring. Jun 4, 2021
@ac1214 ac1214 requested a review from pracucci June 4, 2021 16:31
@ac1214
Fix linting issues
768671b 
Signed-off-by: Albert <ac1214@users.noreply.github.com>
@ac1214
resolve merge conflict
b49d78b 
Signed-off-by: Albert <ac1214@users.noreply.github.com>
@ac1214
Remove duplicate entry from changelog
5b894ff 
Signed-off-by: Albert <ac1214@users.noreply.github.com>
bboreham
bboreham reviewed Jun 17, 2021
View reviewed changes
Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It's broadly ok, but a couple of style points.

It looks to me like the tests you've added test similar code, rather than the code you added. If I'm right, could you test the actual code?

What is the user experience if the timeout is hit? Do they see anything in the logs to let them know what happened?

pkg/compactor/compactor.go Outdated Show resolved Hide resolved
pkg/ring/ring.go Outdated Show resolved Hide resolved
@ac1214
Address PR comments and set timeout to be configurable
1fc181f 
Signed-off-by: Albert <ac1214@users.noreply.github.com>
@ac1214
Merge master
7879deb 
Signed-off-by: Albert <ac1214@users.noreply.github.com>
@ac1214
Copy link
Contributor Author

ac1214 commented Jun 22, 2021 •
edited
Loading

Thanks for the PR! It's broadly ok, but a couple of style points.

It looks to me like the tests you've added test similar code, rather than the code you added. If I'm right, could you test the actual code?

What is the user experience if the timeout is hit? Do they see anything in the logs to let them know what happened?

I added tests to actually test the starting of the compactor. I also added some logging as to make it clear to why the compactor failed to start.

@ac1214 ac1214 requested a review from bboreham June 22, 2021 19:09
@bboreham
Copy link
Contributor

Sorry but we have begun the process of cutting a new release; please rebase from master and move your CHANGELOG entry to the top under ## master / unreleased

pracucci
pracucci reviewed Jun 29, 2021
View reviewed changes
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job and thanks for addressing my feedback. Way easier than the initial version. I left few last comments 🙏

pkg/compactor/compactor.go Outdated Show resolved Hide resolved
pkg/compactor/compactor_ring.go Outdated Show resolved Hide resolved
pkg/compactor/compactor_ring.go Outdated Show resolved Hide resolved
pkg/compactor/compactor_test.go Outdated Show resolved Hide resolved
pkg/ring/util_test.go Outdated Show resolved Hide resolved
@ac1214
Address PR comments and fix tests
b0c5ea3 
Signed-off-by: Albert <ac1214@users.noreply.github.com>
@ac1214
Merge master
eda6517 
Signed-off-by: Albert <ac1214@users.noreply.github.com>
@ac1214
Update unit tests
a4b27b7 
Signed-off-by: Albert <ac1214@users.noreply.github.com>
@ac1214 ac1214 requested a review from pracucci June 30, 2021 17:35
pracucci
pracucci approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (modulo a nit)

CHANGELOG.md Outdated Show resolved Hide resolved
@ac1214
Update changelog and fix linting
d168f25 
Signed-off-by: Albert <ac1214@users.noreply.github.com>
@ac1214
Copy link
Contributor Author

ac1214 commented Jul 1, 2021

Would I be able to get a second review on this PR and get the workflow triggered again? @bboreham
Thanks!

@ac1214
Merge master and resolve merge conflicts
b32c20a 
Signed-off-by: Albert <ac1214@users.noreply.github.com>
bboreham
bboreham approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pracucci
Fixed CHANGELOG entry order
858d5ad 
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci enabled auto-merge (squash) July 5, 2021 15:17
@pracucci pracucci merged commit b4af68a into cortexproject:master Jul 5, 2021
alvinlin123 pushed a commit to ac1214/cortex that referenced this pull request Jan 14, 2022
@ac1214 @pracucci @alvinlin123
Add timeout for waiting on compactor to become ACTIVE in the ring. (c…
da68878 
…ortexproject#4262)

* add MaxRetries to WaitInstanceState

Signed-off-by: Albert <ac1214@users.noreply.github.com>

* update CHANGELOG.md

Signed-off-by: Albert <ac1214@users.noreply.github.com>

* Add timeout for waiting on compactor to become ACTIVE in the ring.

Signed-off-by: Albert <ac1214@users.noreply.github.com>

* add MaxRetries variable back to WaitInstanceState

Signed-off-by: Albert <ac1214@users.noreply.github.com>

* Fix linting issues

Signed-off-by: Albert <ac1214@users.noreply.github.com>

* Remove duplicate entry from changelog

Signed-off-by: Albert <ac1214@users.noreply.github.com>

* Address PR comments and set timeout to be configurable

Signed-off-by: Albert <ac1214@users.noreply.github.com>

* Address PR comments and fix tests

Signed-off-by: Albert <ac1214@users.noreply.github.com>

* Update unit tests

Signed-off-by: Albert <ac1214@users.noreply.github.com>

* Update changelog and fix linting

Signed-off-by: Albert <ac1214@users.noreply.github.com>

* Fixed CHANGELOG entry order

Signed-off-by: Marco Pracucci <marco@pracucci.com>

Co-authored-by: Albert <ac1214@users.noreply.github.com>
Co-authored-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Alvin Lin <alvinlin@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pracucci pracucci pracucci approved these changes

@bboreham bboreham bboreham approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compactor went into tailspin
3 participants
@ac1214 @bboreham @pracucci