Fixes @ modifier when splitting queries by time. #4464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will replace `start` and `end` at (`@`) modifier with the actual constant values based on the original queries. Meaning subqueries will not wrongly use their own query start and end time. Fixes cortexproject#4463 Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
cyriltovena
added a commit
to cyriltovena/cortex
that referenced
this pull request
Sep 21, 2021
It should be 400 and was recently introduced by cortexproject#4464. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
3 tasks
alvinlin123
pushed a commit
that referenced
this pull request
Sep 21, 2021
It should be 400 and was recently introduced by #4464. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
srijan55
pushed a commit
to srijan55/cortex
that referenced
this pull request
Nov 26, 2021
It should be 400 and was recently introduced by cortexproject#4464. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> Signed-off-by: Manish Kumar Gupta <manishkg@microsoft.com>
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
* Fixes @ modifier when splitting queries by time. This will replace `start` and `end` at (`@`) modifier with the actual constant values based on the original queries. Meaning subqueries will not wrongly use their own query start and end time. Fixes cortexproject#4463 Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Update changelog. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> Signed-off-by: Alvin Lin <alvinlin@amazon.com>
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
It should be 400 and was recently introduced by cortexproject#4464. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> Signed-off-by: Alvin Lin <alvinlin@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This will replace
startandendat (@) modifier with the actual constant values based on the original queries.Meaning subqueries will not wrongly use their own query start and end time.
Fixes #4463
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com
Which issue(s) this PR fixes:
Fixes #4463
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]