Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@ modifier is not properly handled by the query-frontend #4463

Closed
2 tasks done
cyriltovena opened this issue Sep 6, 2021 · 0 comments · Fixed by #4464
Closed
2 tasks done

@ modifier is not properly handled by the query-frontend #4463

cyriltovena opened this issue Sep 6, 2021 · 0 comments · Fixed by #4464

Comments

@cyriltovena
Copy link
Contributor

Describe the bug

The query-frontend component currently can split query_ranges by time. (1d)
This allows to parallelize and runs queries faster, however with the recent addition of the @ modifier, splitting queries by times can create incorrect queries specially with the uses of the start() and end(), each sub queries will evaluate it's own start and end modifier.

To Reproduce

Steps to reproduce the behavior:
Run a queries that uses the @ modifier with the start/end() syntax.

http_requests_total @ start()
rate(http_requests_total[5m] @ end())

The result is incorrect compare to Prometheus.

Expected behavior

The frontend should spot those queries before splitting by time and rewrite them using constant value of @ modifier timestamp. @codesome Suggested this solution.

Storage Engine

  • Blocks
  • Chunks
cyriltovena added a commit to cyriltovena/cortex that referenced this issue Sep 6, 2021
@cyriltovena
Fixes @ modifier when splitting queries by time.
7647b8a 
This will replace `start` and `end` at (`@`) modifier with the actual constant values based on the original queries.
Meaning subqueries will not wrongly use their own query start and end time.

Fixes cortexproject#4463

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@cyriltovena cyriltovena mentioned this issue Sep 6, 2021
Merged
2 tasks
cyriltovena added a commit to grafana/mimir that referenced this issue Sep 6, 2021
@cyriltovena
Fixes @ modifier when splitting queries by time.
026af87 
This will replace `start` and `end` at (`@`) modifier with the actual constant values based on the original queries.
Meaning subqueries will not wrongly use their own query start and end time.

see  cortexproject/cortex#4463

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@cyriltovena cyriltovena mentioned this issue Sep 6, 2021
Merged
3 tasks
pstibrany pushed a commit that referenced this issue Sep 7, 2021
@cyriltovena
Fixes @ modifier when splitting queries by time. (#4464)
c00eaf1 
* Fixes @ modifier when splitting queries by time.

This will replace `start` and `end` at (`@`) modifier with the actual constant values based on the original queries.
Meaning subqueries will not wrongly use their own query start and end time.

Fixes #4463

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

* Update changelog.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
bboreham pushed a commit to grafana/mimir that referenced this issue Sep 8, 2021
@cyriltovena
Fixes @ modifier when splitting queries by time. (#206)
7421611 
* Fixes @ modifier when splitting queries by time.

This will replace `start` and `end` at (`@`) modifier with the actual constant values based on the original queries.
Meaning subqueries will not wrongly use their own query start and end time.

see  cortexproject/cortex#4463

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
alvinlin123 pushed a commit to ac1214/cortex that referenced this issue Jan 14, 2022
@cyriltovena @alvinlin123
Fixes @ modifier when splitting queries by time. (cortexproject#4464)
7db58bf 
* Fixes @ modifier when splitting queries by time.

This will replace `start` and `end` at (`@`) modifier with the actual constant values based on the original queries.
Meaning subqueries will not wrongly use their own query start and end time.

Fixes cortexproject#4463

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

* Update changelog.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Alvin Lin <alvinlin@amazon.com>
@yeya24 yeya24 mentioned this issue Nov 1, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes @ modifier when splitting queries by time. cyriltovena/cortex
1 participant
@cyriltovena