Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to provide custom color scheme to charts #1410

Closed
katrinDY opened this issue Aug 25, 2023 · 4 comments
Closed

Add option to provide custom color scheme to charts #1410

katrinDY opened this issue Aug 25, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request frontend Frontend code changes (Javascript, Typescript, Vue.js) video Make video of feature
Milestone

Comments

@katrinDY
Copy link
Contributor

katrinDY commented Aug 25, 2023

In compose ChartConfigurator add a way to create custom chart themes.

Open theme creation(color pickers) in a modal, on modal save, save the theme to compose settings.
This theme must then be available in the color picker to pick and use.

Related files:

  • client/web/compose/src/views/Admin/Charts/Edit.vue
    On line ~100 you'll find the current color picker

This is the view where all of this should happen, except for the modal which would preferably be a separate component (so it can be reusable) for example client/web/compose/src/components/Chart/ThemeModal.vue (or something like that)

@katrinDY katrinDY added enhancement New feature or request frontend Frontend code changes (Javascript, Typescript, Vue.js) labels Aug 25, 2023
@katrinDY katrinDY modified the milestones: 2023.3.x, 2023.9.x Aug 25, 2023
@nagxsan
Copy link

nagxsan commented Aug 28, 2023

Hi @katrinDY ! I would like to take this issue up, could you please let me know a small brief about the issue raised?

@Fajfa Fajfa self-assigned this Aug 29, 2023
@Fajfa
Copy link
Member

Fajfa commented Aug 29, 2023

Hello @daredevil0905, I added a bigger description to the issue, if you need more help do say.
One small thing to add, this is meant for 2023.3.9 which be released end of September. If you can implement it in the next two weeks, otherwise we'll be forced to take over due to the intended release date.

@Fajfa Fajfa modified the milestones: 2023.9.x, 2023.9.0 Aug 29, 2023
@nagxsan
Copy link

nagxsan commented Aug 29, 2023

Thank you @Fajfa ! I will surely try to implement it in the given timeline

@nagxsan
Copy link

nagxsan commented Aug 31, 2023

Hey @Fajfa ! I am really thankful for your opportunity, however due to some other commitments I would not be able to contribute to this issue fully and wholeheartedly as I would want to. And I did not want to waste the crucial time that you have so I wanted to let you know just now itself. I am really sorry for this and I will surely make it up by contributing to a different issue in future.

@Fajfa Fajfa added the video Make video of feature label Sep 28, 2023
@Fajfa Fajfa linked a pull request Oct 4, 2023 that will close this issue
6 tasks
@Fajfa Fajfa linked a pull request Oct 4, 2023 that will close this issue
6 tasks
@Fajfa Fajfa closed this as completed Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Frontend code changes (Javascript, Typescript, Vue.js) video Make video of feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants