Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to manage custom chart color schemes #1467

Closed
wants to merge 3 commits into from
Closed

Add ability to manage custom chart color schemes #1467

wants to merge 3 commits into from

Conversation

Fajfa
Copy link
Member

@Fajfa Fajfa commented Oct 4, 2023

The following changes are implemented

TODO: Summary

Changes in the user interface:

TODO: Add screenshots, recordings or remove this section

Checklist when submitting a final (!draft) PR

  • Commits are tidied up, squashed if needed and follow guidelines in CONTRIBUTING.md
  • Code builds
  • All existing tests pass
  • All new critical code is covered by tests
  • PR is linked to the relevant issue(s)
  • Rebased with the target branch

@Fajfa Fajfa linked an issue Oct 4, 2023 that may be closed by this pull request
Add option to provide custom color scheme to charts #1410
Closed
@Fajfa Fajfa force-pushed the 2023.9.x-feature-custom-chart-color-schemes branch from e92d5b1 to 8b007ba Compare October 5, 2023 09:42
@katrinDY
Copy link
Contributor

katrinDY commented Oct 23, 2023 •
edited

small stuff, otherwise lgtm:

  • getting this error when I delete a currently set custom color scheme
Screenshot 2023-10-23 at 14 32 00
  • getting i18next::translator: missingKey en 0.26937161613852556 chart.openInBuilder chart.openInBuilder when opening the custom color scheme modal/editing a chart with a custom color scheme

@Fajfa Fajfa force-pushed the 2023.9.x-feature-custom-chart-color-schemes branch from 8b007ba to 8d8c752 Compare October 23, 2023 12:12
@Fajfa Fajfa force-pushed the 2023.9.x-feature-custom-chart-color-schemes branch from 8d8c752 to 2508b60 Compare October 23, 2023 14:34
@Fajfa Fajfa closed this Oct 23, 2023
@Fajfa Fajfa deleted the 2023.9.x-feature-custom-chart-color-schemes branch October 24, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to provide custom color scheme to charts
4 participants
@Fajfa @katrinDY @petergrlica @EmmyMay