Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsaved changes logic when a resources is deleted #1466

Merged

Conversation

kelanik8
Copy link
Contributor

@kelanik8 kelanik8 commented Oct 4, 2023

The following changes are implemented

TODO: Summary

Changes in the user interface:

TODO: Add screenshots, recordings or remove this section

Checklist when submitting a final (!draft) PR

  • Commits are tidied up, squashed if needed and follow guidelines in CONTRIBUTING.md
  • Code builds
  • All existing tests pass
  • All new critical code is covered by tests
  • PR is linked to the relevant issue(s)
  • Rebased with the target branch

@kelanik8 kelanik8 requested a review from Fajfa October 4, 2023 07:23
@kelanik8 kelanik8 self-assigned this Oct 4, 2023
@Fajfa Fajfa linked an issue Oct 4, 2023 that may be closed by this pull request
@kelanik8 kelanik8 force-pushed the 2023.3.x-bugfix-unsaved-changes-logic-deleted-resources branch from 61f68d6 to 7e6f993 Compare October 5, 2023 13:44
@kelanik8 kelanik8 changed the base branch from 2023.3.x to 2023.9.x October 19, 2023 09:52
@kelanik8 kelanik8 force-pushed the 2023.3.x-bugfix-unsaved-changes-logic-deleted-resources branch from 7e6f993 to 34d9abe Compare October 19, 2023 09:52
@kelanik8 kelanik8 force-pushed the 2023.3.x-bugfix-unsaved-changes-logic-deleted-resources branch from 34d9abe to 84bfc13 Compare October 24, 2023 12:55
@kelanik8 kelanik8 merged commit 84bfc13 into 2023.9.x Oct 24, 2023
1 check passed
@kelanik8 kelanik8 deleted the 2023.3.x-bugfix-unsaved-changes-logic-deleted-resources branch October 24, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve unsaved changes message logic when a resource is about to be deleted
2 participants