PropertyUsedBeforeDeclaration: fix false positive in nested/inner cla…

…ss (detekt#6139)
cortinico · Jul 15, 2023 · dee1ee8 · dee1ee8
1 parent ad80630
commit dee1ee8
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 1 deletion.
diff --git a/...e/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/PropertyUsedBeforeDeclaration.kt b/...e/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/PropertyUsedBeforeDeclaration.kt
@@ -62,7 +62,7 @@ class PropertyUsedBeforeDeclaration(config: Config = Config.empty) : Rule(config
     override fun visitClassOrObject(classOrObject: KtClassOrObject) {
         super.visitClassOrObject(classOrObject)
 
-        val classMembers = classOrObject.body?.children ?: return
+        val classMembers = classOrObject.body?.children?.filterNot { it is KtClassOrObject } ?: return
 
         val allProperties = classMembers.filterIsInstance<KtProperty>().mapNotNull {
             val name = it.name ?: return@mapNotNull null

diff --git a/...c/test/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/PropertyUsedBeforeDeclarationSpec.kt b/...c/test/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/PropertyUsedBeforeDeclarationSpec.kt
@@ -86,4 +86,44 @@ class PropertyUsedBeforeDeclarationSpec(private val env: KotlinCoreEnvironment)
         val findings = subject.compileAndLintWithContext(env, code)
         assertThat(findings).isEmpty()
     }
+
+    @Test
+    fun `used before declaration in nested object`() {
+        val code = """
+            object Outer {
+                object O {
+                    val inner = outer1
+                }
+            
+                class C {
+                    val inner = outer2
+                }
+            
+                annotation class Ann(val value: String)
+                interface I {
+                    fun f(@Ann(outer3) namedProp: String)
+                }
+            
+                val outer1 = "value1"
+                val outer2 = "value2"
+                const val outer3 = "value3"
+            }
+        """.trimIndent()
+        val findings = subject.compileAndLintWithContext(env, code)
+        assertThat(findings).isEmpty()
+    }
+
+    @Test
+    fun `used before declaration in inner class`() {
+        val code = """
+            class A {
+                inner class B {
+                    val inner = outer
+                }
+                val outer = "value"
+            }
+        """.trimIndent()
+        val findings = subject.compileAndLintWithContext(env, code)
+        assertThat(findings).isEmpty()
+    }
 }