PropertyUsedBeforeDeclaration: fix false positive in nested/inner class #6139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6139 +/- ##
=========================================
Coverage 84.94% 84.94%
- Complexity 4026 4027 +1
=========================================
Files 569 569
Lines 13498 13498
Branches 2381 2381
=========================================
Hits 11466 11466
Misses 869 869
Partials 1163 1163
|
TWiStErRob
reviewed
May 25, 2023
Comment on lines
+117
to
+125
| fun `used before declaration in inner class`() { | ||
| val code = """ | ||
| class A { | ||
| inner class B { | ||
| val inner = outer | ||
| } | ||
| val outer = "value" | ||
| } | ||
| """.trimIndent() |
There was a problem hiding this comment.
Is it worth adding a similar test where the outer is a top-level property, and it is used from a normal class? That sounds like a normal use case.
class C {
val inner = outer
}
val outer = "value"
in this case they're essentially not even nested, just sibling classes. Only Kotlin's syntax allows their declaration in one file.
TWiStErRob
approved these changes
May 25, 2023
BraisGabin
approved these changes
May 28, 2023
schalkms
approved these changes
May 29, 2023
cortinico
added
the
pick request
cortinico
pushed a commit
to cortinico/detekt
that referenced
this pull request
Jul 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6125