Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React-Router #57

Closed
S1E- opened this issue Feb 21, 2016 · 8 comments
Closed

Add React-Router #57

S1E- opened this issue Feb 21, 2016 · 8 comments

Comments

@S1E-
Copy link

S1E- commented Feb 21, 2016

This is great boilerplate but if react router is also added to it then it will be more faster for developers to start developing with it

@coryhouse
Copy link
Owner

I left it out initially because it's not always necessary.

That said, you're not the first to ask. Submit a PR and I'll consider adding it.

@coryhouse
Copy link
Owner

If others really feel strongly about whether React Router belongs in the kit, this is the place to chime in...

@attilad
Copy link

attilad commented Feb 28, 2016

Actually one of the things I like about your kit is that it DOESN'T include it. I use React Router sometimes but I don't need it for every project.

@S1E-
Copy link
Author

S1E- commented Feb 28, 2016

But it is always easier to remove a functionality than adding it.
On 28 Feb 2016 8:25 am, "Attila DeLisle" notifications@github.com wrote:

Actually I like your kit because it DOESN'T include it. I use React Router
sometimes but I don't need it for every project.


Reply to this email directly or view it on GitHub
#57 (comment)
.

@attilad
Copy link

attilad commented Feb 29, 2016

That's a good point.

@PetaPetaPeta
Copy link

It would be nice to have it included along with a toggle function for turning it on or off.

@coryhouse
Copy link
Owner

Great points. I'm open to it if someone submits a pull request. One important point is the example app should be enhanced to have simple navigation in order to display the router working.

@coryhouse
Copy link
Owner

Added in 2.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants