Added yarn. #292
Merged
Added yarn. #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am good with this add. I have been using yarn for a while and having it setup does not affect other devs that are not using it. I will leave it up to @coryhouse, though. |
|
Good stuff. I agree, been quite happy with Yarn. Thanks Nick! 👍 |
This was referenced Jan 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #291
This adds the yarn package manager to react-slingshot. The Travis CI configuration has been updated with the steps provided here https://yarnpkg.com/en/docs/install-ci#travis-tab.
To test this PR:
npm run install -g yarnyarn.On my machine, a Dell XPS 15 i7, SSD, 16 GB, the react-slingshot installation went from about a minute with
npm installto ~18 seconds with Yarn (cold cache) and then to ~7s with Yarn (warm cache).