Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to webpack 3, and upgrade all other dependencies #444

Merged
merged 1 commit into from
Jul 12, 2017
Merged

Upgrade to webpack 3, and upgrade all other dependencies #444

merged 1 commit into from
Jul 12, 2017

Conversation

egdelwonk
Copy link
Contributor

@egdelwonk egdelwonk commented Jul 10, 2017

Haven't done a ton of testing on this branch yet, but so far it looks ok.

This will upgrade to Webpack 3 and upgrades a ton of other packages too. If you'd like, I can try to separate those dependency upgrades out, but figured it'd be useful to get everything up to the latest versions.

Resolves #442

@coveralls
Copy link

coveralls commented Jul 10, 2017

Coverage Status

Coverage decreased (-1.0%) to 94.286% when pulling 27169b3 on egdelwonk:webpack3 into 46b7d26 on coryhouse:master.

@coryhouse coryhouse changed the title Upgrade to webpack 3 Upgrade to webpack 3, and upgrade all other dependencies Jul 10, 2017
@kwelch
Copy link
Collaborator

kwelch commented Jul 10, 2017

Odd that coverage would go down for an non-code change. I will pull this down and test it tonight.

Thanks for the PR, Will!

@kwelch kwelch self-requested a review July 10, 2017 20:55
@kwelch kwelch self-assigned this Jul 10, 2017
@nickytonline
Copy link
Collaborator

Related, #442.

@coryhouse coryhouse merged commit 27169b3 into coryhouse:master Jul 12, 2017
@coryhouse
Copy link
Owner

I made a couple minor tweaks, but looked great. Thanks @egdelwonk 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants