Fixing compatibility with Unity 2019

Removing some features that are only in C# 8.0+
coryleach · Sep 19, 2022 · 3071cf0 · 3071cf0
1 parent 43924b0
commit 3071cf0
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 21 deletions.
diff --git a/Runtime/IReadOnlyStatSet.cs b/Runtime/IReadOnlyStatSet.cs
@@ -4,6 +4,6 @@ namespace Gameframe.StatSheet
 {
     public interface IReadOnlyStatSet<TKey> : IEnumerable<IStatValue<TKey>>
     {
-        public float this[TKey statKey] { get; }
+        float this[TKey statKey] { get; }
     }
 }
diff --git a/Runtime/IStatSet.cs b/Runtime/IStatSet.cs
@@ -4,6 +4,6 @@ namespace Gameframe.StatSheet
 {
     public interface IStatSet<TKey> : IEnumerable<IStatValue<TKey>>, IReadOnlyStatSet<TKey>
     {
-        public new float this[TKey statKey] { get; set; }
+        new float this[TKey statKey] { get; set; }
     }
 }
diff --git a/Runtime/IStatValue.cs b/Runtime/IStatValue.cs
@@ -7,24 +7,25 @@ public interface IStatValue<TKey>
         TKey StatType { get; }
         float Value { get; }
 
-        public static IStatValue<TKey> operator +(IStatValue<TKey> lhs, IStatValue<TKey> rhs)
-        {
-            Debug.Assert(lhs.StatType.Equals(rhs.StatType), "stat types do not match");
-            return new StatValue<TKey>
-            {
-                StatType = lhs.StatType,
-                Value = (lhs.Value + rhs.Value)
-            };
-        }
-
-        public static IStatValue<TKey> operator -(IStatValue<TKey> lhs, IStatValue<TKey> rhs)
-        {
-            Debug.Assert(lhs.StatType.Equals(rhs.StatType), "stat types do not match");
-            return new StatValue<TKey>
-            {
-                StatType = lhs.StatType,
-                Value = (lhs.Value - rhs.Value)
-            };
-        }
+        // Operators in interfaces not available until C# 8.0+
+        // public static IStatValue<TKey> operator +(IStatValue<TKey> lhs, IStatValue<TKey> rhs)
+        // {
+        //     Debug.Assert(lhs.StatType.Equals(rhs.StatType), "stat types do not match");
+        //     return new StatValue<TKey>
+        //     {
+        //         StatType = lhs.StatType,
+        //         Value = (lhs.Value + rhs.Value)
+        //     };
+        // }
+        //
+        // public static IStatValue<TKey> operator -(IStatValue<TKey> lhs, IStatValue<TKey> rhs)
+        // {
+        //     Debug.Assert(lhs.StatType.Equals(rhs.StatType), "stat types do not match");
+        //     return new StatValue<TKey>
+        //     {
+        //         StatType = lhs.StatType,
+        //         Value = (lhs.Value - rhs.Value)
+        //     };
+        // }
     }
 }