add additional printer columns #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodesousa
force-pushed
the
add_custom_columns
branch
2 times, most recently
from
1330978
to
2d150a9
Compare
|
Closes #8 |
|
Awesome, thanks for this. It looks good, I have a few nitpicks. I'll add some suggested changes a little later today. |
rodesousa
force-pushed
the
add_custom_columns
branch
2 times, most recently
from
cf705f0
to
9e809b0
Compare
coryodaniel
requested changes
May 22, 2019
|
Can you apply that one suggestion and add this feature to the [changelog][https://github.com/coryodaniel/bonny/blob/master/CHANGELOG.md] under 'unreleased' |
rodesousa
force-pushed
the
add_custom_columns
branch
from
9e809b0
to
21520e8
Compare
Signed-off-by: rodesousa <dessroberto@gmail.com>
rodesousa
force-pushed
the
add_custom_columns
branch
from
21520e8
to
e6ec08a
Compare
coryodaniel
approved these changes
Jun 3, 2019
|
Thanks! I'm hoping to cut a new release this week. I'll ping this ticket when I do! |
|
=) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented customs columns for kubectl.
Official documentation: https://kubernetes.io/docs/tasks/access-kubernetes-api/custom-resources/custom-resource-definitions/#additional-printer-columns