Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic fix-up #5

Merged
merged 20 commits into from Oct 21, 2015
Merged

Basic fix-up #5

merged 20 commits into from Oct 21, 2015

Conversation

jonathanstowe
Copy link
Collaborator

Hi,
It seemed a shame that this wasn't working on a current rakudo and I fancied a change from what I was doing :)

This makes all the existing tests pass, I only added one TODO as it seemed to be time sensitive on my machine.

I'm not an expert on memcached by any token so it may not working completely correctly, but certainly enough for people to start using.

Anyhow thanks for the module.

@jonathanstowe
Copy link
Collaborator Author

Just fixed it back so that it will merge cleanly, still passes all the tests.

[jonathan@cannibal perl6-cache-memcached]$ panda-test
t/001_use.t ................ ok
t/010_internals.t .......... ok

Server version: 1.4.17

t/020_keys.t ............... ok
t/030_stats.t .............. ok
t/040_noreply.t ............ ok
t/050_reconnect_timeout.t .. ok
t/060_utf8_key.t ........... ok
t/100_flush_bug.t .......... ok
t/999_connect.t ............ ok
All tests successful.

Test Summary Report

t/050_reconnect_timeout.t (Wstat: 0 Tests: 2 Failed: 0)
TODO passed: 2
Files=9, Tests=76, 80 wallclock secs ( 0.14 usr 0.02 sys + 77.87 cusr 1.19 csys = 79.22 CPU)
Result: PASS

@jonathanstowe
Copy link
Collaborator Author

Hi,
This brings it up to date and working with the latest Rakudo. It would be really nice if this could be made to work again.

Let me know if there is anything I can do to help.

cosimo added a commit that referenced this pull request Oct 21, 2015
@cosimo cosimo merged commit dc06e78 into cosimo:master Oct 21, 2015
@jonathanstowe
Copy link
Collaborator Author

Cool, cheers matey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants