Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the module semi-functional #11

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

AlexDaniel
Copy link

@AlexDaniel AlexDaniel commented Aug 5, 2018

I attempted to fix the module during the squashathon.

So it compiles and works now, and some tests in basic.t pass. However, it fails on:

my $fact = $facter.fact($test-fact);
ok($fact, "test fact is loaded");

I was trying to add missing pieces but the module seems to be unfinished? I think the test file needs to set facter_perl6os=perl6os env var, or something like that. But I didn't manage to get it to chooch.

BTW I think PRs #3 #4 and #5 can be closed (no longer needed).

@AlexDaniel
Copy link
Author

Any reason not to merge this? 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant