V6 #216

davidtheclark · 2019-10-06T17:31:14Z

Development of V6 has taken longer than expected, so I've opened the branch v6 for that work and reverted master to 5.2.1 to avoid confusion.

We'll merge v6 work into this branch, then merge it into master when it's ready for release.

Closes #168.

… features stopped being added

The "coverage" script looks to have been replaced previously using jest's configuration. I checked both CI scripts and do not see this being used anywhere

… excess eslint config file note: convert eslint config to js - enables proper comments and variables

…iple Cache types and standardize cacheWrapper calls

… packages

chrisblossom · 2019-10-23T00:44:57Z

I think I solved all open issues including removing the hacky code from index.test.ts. I'm okay with merging and releasing at this PR's current state as long as everyone else is.

@olsonpm can you confirm this is what you had in mind: 60337c9

Questionable commits:

`Object.freeze(defaultLoaders)`: `7a0f0e6`

I am not sure if Object.freeze this will slowdown the initial load time of this library. I doubt it will considering how small of an object it is.

Remove `yarn.lock` `fad0ebc`

This closes #206. If this is not wanted, please revert the commit and close the issue. It isn't a big deal to me either way. I added it because it was the last thing I could think of that I might have put a PR in for v6.

olsonpm · 2019-10-23T00:53:29Z

i'm not at my computer but the only thing i would add is the file name in the error message similar to how the error is caught and the filename prepended to error message in the loader above

chrisblossom · 2019-10-23T01:01:30Z

i'm not at my computer but the only thing i would add is the file name in the error message similar to how the error is caught and the filename prepended to error message in the loader above

Good idea. I'll add that tomorrow and hopefully figure out why the windows tests are failing.

This reverts commit fad0ebc.

chrisblossom · 2019-10-23T21:16:39Z

In 358104c I added the file path to the yaml error and fixed the windows errors in db8f2cd.

Quick note about the removing yarn.lock commit. I'm not trying to force the change by committing it, it really doesn't matter to me. I just wanted to move on from this PR and that was the last thing I could think of. Please revert the commit for any reason.

Are there any other changes anyone thinks should be done?

chrisblossom · 2019-10-23T21:56:51Z

test/caches.test.ts

+// This test does not work with lazy loading JS -- TODO: fix or remove
+// eslint-disable-next-line jest/no-disabled-tests
+describe.skip('ensure import-fresh is called when loading a js file', () => {


I am unsure how to fix this test. I don't understand the point of the test, don't we know that by requiring it?. I personally think we should just remove it and move on.

chrisblossom · 2019-10-23T21:58:32Z

Commit 08ebcd5 I took the idea from #214 and lazy loaded all default loaders. Any negatives from doing this?

davidtheclark · 2019-10-26T16:48:22Z

@chrisblossom Great work.

Object.freeze seems fine to me.
The lazy loading seems like a good idea and I don't know any reasons not to. We'll see if anybody finds any!
I don't know if I'm fully on board about yarn.lock but I or others can re-add it later if we think it's important, no big deal.
Deleting that import-fresh test seems ok to me. I will say after this experience I'm kind of skeptical about whether it's worth type-checking test files, because it seems to make stubbing/mocking/spying so much harder, with unclear benefits. But we have it working for now!

I pushed commit ed83eaa with some documentation and changelog adjustments. I think we're ready to launch.

Can anybody please chime in if you think we need to wait? If not, I'll merge & publish the release tomorrow (Sunday).

chrisblossom · 2019-10-26T17:49:51Z

I can't think of anymore changes and I'm good with merging / releasing.

Deleting that import-fresh test seems ok to me. I will say after this experience I'm kind of skeptical about whether it's worth type-checking test files, because it seems to make stubbing/mocking/spying so much harder, with unclear benefits. But we have it working for now!

The import-fresh issue had nothing to do with types. It is a jest mocking / require issue.

davidtheclark · 2019-11-02T16:11:39Z

I released V6 this morning — decided not to spent more time fussing about the lazy requiring, and just see if users have problems with it (the stakes, I think, are pretty low). Nice work! 🍰 🍰 🍰

koenpunt and others added 30 commits May 18, 2019 08:35

Fail CI if package.json and yarn lock are out of sync (#186)

5210758

Warn against filename-unfriendly chars in moduleName (#187)

0a84b90

Closes #168.

Remove support for Node 4 and 6 (#190)

d49dad0

update packages

0783a34

fix npm config to correctly remove package-lock.json

a7c760e

enable test undefined checks

e8a16e9

set prettier trailingComma to all

1b452bc

set node/no-unsupported-features to first node 8 LTS release when new…

6003890

… features stopped being added

use prettier for all supported file types (except markdown) (#193)

6da6871

add eslint-plugin-jest (#196)

26a961a

use babel to compile source

128e42c

remove unused coverage script

5560b29

The "coverage" script looks to have been replaced previously using jest's configuration. I checked both CI scripts and do not see this being used anywhere

add pre-push git hook, and consolidate all checks into check:all script

b68a566

eslint: remove plugin-node from src enable module parsing, and remove…

1d4b35b

… excess eslint config file note: convert eslint config to js - enables proper comments and variables

convert common-js to es modules named exports

8f7d24a

move flow-typed/defs.js to src/types.js and remove unused types

53d2d40

migrate build system to typescript

748a03c

remove flow comments

f9c6880

test files to typescript

e2e5dd9

source files to typescript

ed37ddd

run prettier on all files

cb058a1

rename all files to .ts and update changelog

0ea62ce

Typescript code quality tools (#202)

47d8951

export Options and combine multiple Options definitions

0e10c02

export Transform and add correctly type it can be a Promise (async only)

709ca57

fix cacheWrapper to cache the result instead of a Promise, merge mult…

f18cf0c

…iple Cache types and standardize cacheWrapper calls

export LoaderSync and LoaderAsync

0d7b647

correctly type LoadedFileContent

e98bd6a

split loadFileContent into async / sync separate functions

c6ef21d

use default function parameters

5a7053e

chrisblossom added 7 commits October 22, 2019 13:51

export actual defaultLoaders object

26b65bb

freeze defaultLoaders so it cannot be mutated causing unexpected results

7a0f0e6

update changelog

83ff4b1

replace js-yaml with yaml

60337c9

update all packages and ensure prefix is correctly set for future npm…

6935c0f

… packages

refactor test/index.test.ts to remove jest inline snapshot hacks

1e1ae77

remove yarn.lock

fad0ebc

chrisblossom added 4 commits October 23, 2019 10:31

Revert "remove yarn.lock"

080256a

This reverts commit fad0ebc.

Include absolute file path to yaml parse error

358104c

windows del fix

db8f2cd

remove yarn.lock

c8c8817

Lazy load all default loaders

08ebcd5

chrisblossom reviewed Oct 23, 2019

View reviewed changes

Prepare 6.0.0

ed83eaa

davidtheclark force-pushed the v6 branch from eca8270 to ed83eaa Compare October 26, 2019 16:47

Fix typo

b7b2ae6

This was referenced Oct 28, 2019

Remove createRuleTester stylelint/stylelint#4267

Closed

plan cosmiconfig v6 to next future-major stylelint/stylelint#4386

Closed

davidtheclark merged commit d26b105 into master Nov 2, 2019

davidtheclark deleted the v6 branch November 2, 2019 16:02

davidtheclark mentioned this pull request Nov 2, 2019

Remove yarn.lock #206

Closed

ntwb mentioned this pull request May 26, 2022

Refactor to replace cosmiconfig with lilconfig and js-yaml stylelint/stylelint#6101

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V6 #216

V6 #216

davidtheclark commented Oct 6, 2019 •

edited

chrisblossom commented Oct 23, 2019

olsonpm commented Oct 23, 2019

chrisblossom commented Oct 23, 2019

chrisblossom commented Oct 23, 2019 •

edited

chrisblossom Oct 23, 2019

chrisblossom commented Oct 23, 2019 •

edited

davidtheclark commented Oct 26, 2019

chrisblossom commented Oct 26, 2019

davidtheclark commented Nov 2, 2019

V6 #216

V6 #216

Conversation

davidtheclark commented Oct 6, 2019 • edited

chrisblossom commented Oct 23, 2019

Object.freeze(defaultLoaders): 7a0f0e6

Remove yarn.lock fad0ebc

olsonpm commented Oct 23, 2019

chrisblossom commented Oct 23, 2019

chrisblossom commented Oct 23, 2019 • edited

chrisblossom Oct 23, 2019

Choose a reason for hiding this comment

chrisblossom commented Oct 23, 2019 • edited

davidtheclark commented Oct 26, 2019

chrisblossom commented Oct 26, 2019

davidtheclark commented Nov 2, 2019

davidtheclark commented Oct 6, 2019 •

edited

`Object.freeze(defaultLoaders)`: `7a0f0e6`

Remove `yarn.lock` `fad0ebc`

chrisblossom commented Oct 23, 2019 •

edited

chrisblossom commented Oct 23, 2019 •

edited