not starting kafkaproducer in integration tests

server/benchmarking_fetch_test.go

@@ -12,6 +12,7 @@ import (
 	"strconv"
 	"testing"
 	"time"
+	"github.com/cosminrentea/gobbler/server/configstring"
 )
 
 func Benchmark_E2E_Fetch_HelloWorld_Messages(b *testing.B) {
@@ -27,6 +28,8 @@ func Benchmark_E2E_Fetch_HelloWorld_Messages(b *testing.B) {
 	*Config.StoragePath = dir
 	*Config.WS.Enabled = true
 	*Config.WS.Prefix = "/stream/"
+	*Config.KafkaProducer.Brokers = configstring.List{}
+
 	service := StartService()
 	defer service.Stop()
 

server/benchmarking_test.go

@@ -13,6 +13,7 @@ import (
 	"github.com/cosminrentea/gobbler/client"
 	"github.com/cosminrentea/gobbler/protocol"
 	"github.com/cosminrentea/gobbler/testutil"
+	"github.com/cosminrentea/gobbler/server/configstring"
 )
 
 type testgroup struct {
@@ -50,6 +51,7 @@ func TestThroughput(t *testing.T) {
 	*Config.StoragePath = dir
 	*Config.WS.Enabled = true
 	*Config.WS.Prefix = "/stream/"
+	*Config.KafkaProducer.Brokers = configstring.List{}
 
 	service := StartService()
 

server/config_test.go

@@ -196,7 +196,7 @@ func assertArguments(a *assert.Assertions) {
 	a.Equal("dev", *Config.EnvName)
 	a.Equal("mem", *Config.Profile)
 
-	a.Equal("[ 127.0.0.1:9092 127.0.0.1:9091]", (*Config.KafkaProducer.Brokers).String())
+	a.Equal("[127.0.0.1:9092 127.0.0.1:9091]", (*Config.KafkaProducer.Brokers).String())
 	a.Equal("sms_reporting_topic", *Config.SMS.KafkaReportingTopic)
 
 	assertClusterRemotes(a)

server/configstring/configstringlist.go

@@ -34,8 +34,12 @@ func (sl *List) IsEmpty() bool {
 
 func (sl List) String() string {
 	res := "["
-	for _, s := range sl {
-		res = res + " " + s
+	for i, s := range sl {
+		if i == 0 {
+			res = res + s
+		} else {
+			res = res + " " + s
+		}
 	}
 	res = res + "]"
 	return res

server/configstring/configstringlist_test.go

@@ -14,7 +14,11 @@ func TestList_IsEmpty(t *testing.T) {
 	m := NewMockSettings(ctrl)
 	m.EXPECT().SetValue(gomock.Any())
 
-	cs := NewFromKingpin(m)
+	listFromKingpin := NewFromKingpin(m)
 
-	assert.True(t, cs.IsEmpty())
+	assert.True(t, listFromKingpin.IsEmpty())
+
+	list := &List{}
+
+	assert.True(t, list.IsEmpty())
 }

server/fcm_integration_test.go

@@ -18,6 +18,7 @@ import (
 	"github.com/cosminrentea/gobbler/server/service"
 	"github.com/cosminrentea/gobbler/testutil"
 	"github.com/stretchr/testify/assert"
+	"github.com/cosminrentea/gobbler/server/configstring"
 )
 
 var (
@@ -142,6 +143,7 @@ func serviceSetUp(t *testing.T) (*service.Service, func()) {
 	*Config.FCM.Prefix = "/fcm/"
 	*Config.FCM.Workers = 1 // use only one worker so we can control the number of messages that go to FCM
 	*Config.APNS.Enabled = false
+	*Config.KafkaProducer.Brokers = configstring.List{}
 
 	var s *service.Service
 	for s == nil {

server/gobbler_test.go

@@ -12,6 +12,7 @@ import (
 	"reflect"
 	"strings"
 	"testing"
+	"github.com/cosminrentea/gobbler/server/configstring"
 )
 
 func TestValidateStoragePath(t *testing.T) {
@@ -115,6 +116,7 @@ func TestStartServiceModules(t *testing.T) {
 	*Config.FCM.Enabled = false
 	*Config.APNS.Enabled = false
 	*Config.WS.Enabled = false
+	*Config.KafkaProducer.Brokers = configstring.List{}
 
 	// using an available port for http
 	testHttpPort++

server/integration_test.go

@@ -18,13 +18,16 @@ import (
 
 	"github.com/cosminrentea/gobbler/restclient"
 	"github.com/cosminrentea/gobbler/testutil"
+	"github.com/cosminrentea/gobbler/server/configstring"
 )
 
 func initServerAndClients(t *testing.T) (*service.Service, client.Client, client.Client, func()) {
 	*Config.HttpListen = "localhost:0"
 	*Config.KVS = "memory"
 	*Config.WS.Enabled = true
 	*Config.WS.Prefix = "/stream/"
+	*Config.KafkaProducer.Brokers = configstring.List{}
+
 	s := StartService()
 
 	time.Sleep(time.Millisecond * 100)