Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override registration disable #43

Closed
wants to merge 2 commits into from
Closed

Conversation

dan-it
Copy link

@dan-it dan-it commented Nov 13, 2016

Add config checkbox to override if registration is disabled. If checked
registration will be always possible from oauth.

Add config checkbox to override if registration is disabled. If checked
registration will be always possible from oauth.
@yennor
Copy link

yennor commented Apr 27, 2018

i've tested that patch and it works :-)

@rasos
Copy link

rasos commented Jun 16, 2018

@splitbrain could we get this merged - desperately needed to prevent people registering when they should use the oauth built in registration. Hiding the register button by CSS does not keep bots away to register.

@XA21X
Copy link

XA21X commented Sep 21, 2018

I don't believe there's a functional difference, but the docs state that the onoff class should be of type integer instead of boolean. The current default false should be replaced with 0?

Thanks to Xa21X for noticing: cosmocode#43 (comment) - replaced default with 0
@dan-it
Copy link
Author

dan-it commented Sep 21, 2018

Seems legit. Replaced in the code.

@jeffdgr8
Copy link

Great PR! We require this function for our internal wiki use case, where only emails in a specific domain are allowed to authenticate and accounts should be created automatically for new users. All logins are through Google.

I might suggest adding something like $lang['override-newreg'] = 'Allow OAuth user creation even when registration is disabled'; to lang/en/settings.php (other language translations eventually) as a description for the setting.

@splitbrain
Copy link
Member

this feature is already part of the current plugin

@splitbrain splitbrain closed this Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants