Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image type is actually MediaType #38

Closed
micgro42 opened this issue Feb 26, 2016 · 2 comments
Closed

Image type is actually MediaType #38

micgro42 opened this issue Feb 26, 2016 · 2 comments
Labels
bug needs discussion todo
Milestone
SPR-2016/2

Comments

@micgro42
Copy link
Contributor

Currently (local?) videos and audio files seem to work as well within the image type. I guess we should either enforce a check on the mime-type or rename the type to media.

This has been introduced by #13 and #26.
@splitbrain
Copy link
Member

Good point. I guess it makes sense to rename it to media. Maybe we could introduce an optional config to restrict the field to a certain mime-type.

@stvoigt
Copy link

stvoigt commented Mar 2, 2016

I like that media-type. I does work with pdf as well. The problem than is only, that you cannot open it, because this "slideshow/gallery" style pops up and tries to display an image or something like that...

splitbrain added a commit that referenced this issue Mar 2, 2016
@splitbrain
renamed Image to Media and added mime type validation #38
25caf3d
@splitbrain splitbrain mentioned this issue Mar 2, 2016
Merged
1 task
splitbrain added a commit that referenced this issue Mar 3, 2016
@splitbrain
Merge branch 'master' into usertype
a92c2a0 
* master:
  automatically change the type for existing Image fields
  added tests for PDF and Video
  more Media type tests
  renamed classes to match type
  added media type validation tests
  renamed Image to Media and added mime type validation #38
@splitbrain splitbrain modified the milestone: SPR- 2016/3 Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug needs discussion todo
Projects
None yet
Milestone
SPR-2016/2
Development

No branches or pull requests
3 participants
@splitbrain @stvoigt @micgro42