Add image type #26
Merged
Add image type #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SPR-322, GitHub Issue #13
|
Gallery / Lightbox:
|
| * @return bool true if $mode could be satisfied | ||
| */ | ||
| public function renderValue($value, \Doku_Renderer $R, $mode) { | ||
| if (!empty($value)) { |
There was a problem hiding this comment.
I believe we do not render empty values? We should set up some rules on what types do not need to check themselves (like validate() is never called for blank fields).
| if ($mode == 'xhtml') { | ||
| $renderer->doc .= '<div class="table structaggegation">'; | ||
| $renderer->doc .= "<div class=\"table structaggregation hash:$hash\">"; |
There was a problem hiding this comment.
I'm not sure if this is a valid class name. Why not data-hash=$hash?
* master: use different branch now that the event has been merged default to translated column labels in table aggregation Show struct differences in diff view. SPR-31 closes #4 remove empty values withing multivals fix entry tests edit form styling SPR-320 added JavaScript for adding new inputs to multi edit fields
* renamed from Img to Image * added height and width configuration * fixed the handling for multi edit fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToDo:
This pull request is requires the changes of dokuwiki/dokuwiki#1479. It also makes use of the changes of dokuwiki/dokuwiki#1472.
When merged, this pull request closes #13.