Validation Refactor #165
Merged
Validation Refactor #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Validator is now returned by the AccessTable. It has it's own save method. The entry.php was split up in entry, edit and revert to separate the different concerns. Validation is only done in entry and the thanks to the new Validator mechanism, the once loaded access table is reused in saving. This will break all kind of stuff. Fixing that is for the upcoming commits
this is needed because the object may be reused during testing
This just renames the parameter to make this more clear
* lookups: test translation feature implement rendering via sub type in Dropdown fix displayValue for looked up type, more tests fixed constructor signature first test for new Dropdown features adjusted tests for renamed aliases Add Lookup Support to Dropdown column aliases need to differ from real column names use display value as default renderer introduces getDisplayValue
|
looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As commented at #147 (comment) this refactors the Validation mechanism, to avoid reinstantiating the access table classes.