New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation Refactor #165
Merged
Merged
Validation Refactor #165
Commits on Aug 23, 2016
-
first start at refactoring the validation mechanism
A Validator is now returned by the AccessTable. It has it's own save method. The entry.php was split up in entry, edit and revert to separate the different concerns. Validation is only done in entry and the thanks to the new Validator mechanism, the once loaded access table is reused in saving. This will break all kind of stuff. Fixing that is for the upcoming commits
Configuration menu - View commit details
-
Copy full SHA for 87dc134 - Browse repository at this point
Copy the full SHA 87dc134View commit details -
Configuration menu - View commit details
-
Copy full SHA for f392071 - Browse repository at this point
Copy the full SHA f392071View commit details -
reset tosave on each validation run
this is needed because the object may be reused during testing
Configuration menu - View commit details
-
Copy full SHA for 67036da - Browse repository at this point
Copy the full SHA 67036daView commit details -
Validation should happen on raw value
This just renames the parameter to make this more clear
Configuration menu - View commit details
-
Copy full SHA for 23169ab - Browse repository at this point
Copy the full SHA 23169abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 93ca6f4 - Browse repository at this point
Copy the full SHA 93ca6f4View commit details
Commits on Aug 24, 2016
-
Configuration menu - View commit details
-
Copy full SHA for b6c8d1e - Browse repository at this point
Copy the full SHA b6c8d1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f33ae07 - Browse repository at this point
Copy the full SHA f33ae07View commit details -
Merge branch 'lookups' into validationrefactor
* lookups: test translation feature implement rendering via sub type in Dropdown fix displayValue for looked up type, more tests fixed constructor signature first test for new Dropdown features adjusted tests for renamed aliases Add Lookup Support to Dropdown column aliases need to differ from real column names use display value as default renderer introduces getDisplayValue
Configuration menu - View commit details
-
Copy full SHA for dd6a2b7 - Browse repository at this point
Copy the full SHA dd6a2b7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.