Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation Refactor #165

Merged
merged 8 commits into from Aug 24, 2016
Merged

Validation Refactor #165

merged 8 commits into from Aug 24, 2016

Commits on Aug 23, 2016

  1. first start at refactoring the validation mechanism

    A Validator is now returned by the AccessTable. It has it's own save
    method. The entry.php was split up in entry, edit and revert to separate
    the different concerns. Validation is only done in entry and the thanks
    to the new Validator mechanism, the once loaded access table is reused
    in saving.
    
    This will break all kind of stuff. Fixing that is for the upcoming
    commits
    splitbrain committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    87dc134 View commit details
    Browse the repository at this point in the history
  2. use factory again

    splitbrain committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    f392071 View commit details
    Browse the repository at this point in the history
  3. reset tosave on each validation run

    this is needed because the object may be reused during testing
    splitbrain committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    67036da View commit details
    Browse the repository at this point in the history
  4. Validation should happen on raw value

    This just renames the parameter to make this more clear
    splitbrain committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    23169ab View commit details
    Browse the repository at this point in the history
  5. more Validator refactoring

    splitbrain committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    93ca6f4 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2016

  1. Configuration menu
    Copy the full SHA
    b6c8d1e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f33ae07 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'lookups' into validationrefactor

    * lookups:
      test translation feature
      implement rendering via sub type in Dropdown
      fix displayValue for looked up type, more tests
      fixed constructor signature
      first test for new Dropdown features
      adjusted tests for renamed aliases
      Add Lookup Support to Dropdown
      column aliases need to differ from real column names
      use display value as default renderer
      introduces getDisplayValue
    splitbrain committed Aug 24, 2016
    Configuration menu
    Copy the full SHA
    dd6a2b7 View commit details
    Browse the repository at this point in the history