Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dockerfile to build inside a docker container #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add dockerfile to build inside a docker container #11

wants to merge 3 commits into from

Conversation

NicolasMahe
Copy link

@NicolasMahe NicolasMahe commented Jan 30, 2020

This PR adds a dockerfile and instructions to use docker to run and build this library inside a controlled environment.

I didn't want to install GopherJS on my machine because of the old go version required, so I end up running it in a container.

Quick guide:

# build the image
docker build .

# run `yarn publish`
docker run --rm -it -v $(PWD)/dist:/project/dist -v $(PWD)/types:/project/types $(docker build -q .) yarn publish

@jordaaash
Copy link
Contributor

Thanks for the PR! This is a good idea, I'll test it out and see if it works for me.

@@ -26,7 +26,7 @@
"go": "cd go/js && gopherjs build -v -o ../../lib/Amino.js .",
"go:min": "yarn go -m",
"go:watch": "yarn go -w",
"gzip": "gzip -kf dist/*.{js,map}",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i changed this because it was not working inside the debian docker container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants