fix(faucet): isValidAddress should accept all bech32 addresses
#1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xpatrickdev
force-pushed
the
faucet-is-valid-address
branch
from
3d29946
to
c512de3
Compare
- check length based on Bech32 from [BIP173](https://github.com/bitcoin/bips/blob/e1e7b77c027b3d40d07d306cc75c2b5859c91db2/bip-0173.mediawiki#bech32)
0xpatrickdev
force-pushed
the
faucet-is-valid-address
branch
from
c512de3
to
a65fd8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
isValidAddressfunction to accept a wider range of valid addresses, including account addresses from Interchain Accounts (ICS-27). The updated implementation removes the fixed length check and replaces it with a more flexible validation based on the Bech32 specification from BIP173.