Support IBC MsgTransfer #128
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
abefernan
force-pushed
the
feat/support-ibc-msgtransfer
branch
from
57ccc9b
to
e1899eb
Compare
types/txMsg.ts
Outdated
| type OmmitedMsgTransfer = Omit<MsgTransfer, "timeoutHeight" | "memo">; | ||
| type MsgTransferRequiredToken = OmmitedMsgTransfer & Required<Pick<OmmitedMsgTransfer, "token">>; | ||
| interface MsgTransferOptionalMemo extends MsgTransferRequiredToken { | ||
| readonly memo?: string; |
There was a problem hiding this comment.
Why not keep this required and just set it empty when the user does not put in text?
There was a problem hiding this comment.
I thought it was weird that the comment of the type said "optional field" and the field was not optional, but it's not important, I can remove it
There was a problem hiding this comment.
This is a problem coming from Go and protobuf. There the something is called "optional" wen it is allowed to be empty. Since at transaction level undefined and "" are the same thing we don't need to differentiate it here.
| {humanTimestampOptions.map(({ label }) => ( | ||
| <option key={label}>{label}</option> | ||
| ))} | ||
| </datalist> |
There was a problem hiding this comment.
I tried this dropdown in the Vercel preview. But it seems like after it was set once you cannot change it anymore.
There was a problem hiding this comment.
Ah it seems it filters the list, maybe I can clear the field on click so all the options appear
Part of #99.
Closes #127.