Validate macrocoin, allow empty funds and IBC #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
abefernan
changed the title
abefernan
changed the title
webmaster128
reviewed
Feb 8, 2024
| }); | ||
|
|
||
| console.log({ msgValue }); |
| @@ -102,6 +107,13 @@ const MsgInstantiateContractForm = ({ | |||
| return false; | |||
| } | |||
|
|
|||
| try { | |||
| macroCoinToMicroCoin({ denom, amount }, chain.assets); | |||
There was a problem hiding this comment.
Yeah the implementation has exceeded the logic behind the initial name I gave it
webmaster128
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #180.
Closes #183.
Closes #191.
Closes #192.
#180 was because of missing validation.
#183 and #192 because we didn't account for IBC tokens not disclosed on the chain-registry.
#191 because if funds/amount was an array, we sent an empty coin instead of an empty array.