cosmos-sdk-proto: replace TypeUrl with Name trait
#432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Name` trait added upstream in `prost` can be used to compute the type URL using `Name::type_url`: tokio-rs/prost#896 The new `Any::{from_msg, to_msg}` methods can be used to serialize `Message` types to/from messages. This commit switches from the `TypeUrl` trait to `Name` and relies more on upstream functionality in `prost`. Unfortunately it shipped with a bug in the default `Name::full_name` method, so a workaround is temporarily used until a fix ships: tokio-rs/prost#923
tony-iqlusion
force-pushed
the
cosmos-sdk-proto/replace-typeurl-with-name-trait
branch
from
c7a3e03
to
0b01017
Compare
tony-iqlusion
deleted the
cosmos-sdk-proto/replace-typeurl-with-name-trait
branch
This was referenced Oct 3, 2023
Closed
Merged
|
Is this reversed now that prost-types has had a named release ? |
felipepimsil
pushed a commit
to felipepimsil/cosmos-rust
that referenced
this pull request
Dec 18, 2023
The `Name` trait added upstream in `prost` can be used to compute the type URL using `Name::type_url`: tokio-rs/prost#896 The new `Any::{from_msg, to_msg}` methods can be used to serialize `Message` types to/from messages. This commit switches from the `TypeUrl` trait to `Name` and relies more on upstream functionality in `prost`. Unfortunately it shipped with a bug in the default `Name::full_name` method, so a workaround is temporarily used until a fix ships: tokio-rs/prost#923
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Nametrait added upstream inprostcan be used to compute the type URL usingName::type_url: tokio-rs/prost#896The new
Any::{from_msg, to_msg}methods can be used to serializeMessagetypes to/from messages.This commit switches from the
TypeUrltrait toNameand relies more on upstream functionality inprost.Unfortunately it shipped with a bug in the default
Name::full_namemethod, so a workaround is temporarily used until a fix ships: tokio-rs/prost#923