Fixed Coins IsValid, issue #8

cosmos · Jan 31, 2017 · 2f7875d · 2f7875d
1 parent 6e3a199
commit 2f7875d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/types/coin.go b/types/coin.go
@@ -35,6 +35,8 @@ func (coins Coins) IsValid() bool {
 			if coin.Amount == 0 {
 				return false
 			}
+			// we compare each coin against the last denom
+			lowDenom = coin.Denom
 		}
 		return true
 	}

diff --git a/types/coin_test.go b/types/coin_test.go
@@ -42,6 +42,19 @@ func TestCoinsBadSort(t *testing.T) {
 	}
 }
 
+func TestCoinsBadSort2(t *testing.T) {
+	// both are after the first one, but the second and third are in the wrong order
+	coins := Coins{
+		Coin{"GAS", 1},
+		Coin{"TREE", 1},
+		Coin{"MINERAL", 1},
+	}
+
+	if coins.IsValid() {
+		t.Fatal("Coins are not sorted")
+	}
+}
+
 func TestCoinsBadAmount(t *testing.T) {
 	coins := Coins{
 		Coin{"GAS", 1},