Skip to content

Commit

Permalink
chore(group): State machine audit (#11559)
Browse files Browse the repository at this point in the history
## Description

ref: #10968 

I would like to have some eyes to:

- Make sure the state machine vulnerabiities are indeed bugs that should be fixed:
  - [x] #11559 (comment)
  - [x] #11559 (comment)
  - [x] #11559 (comment)
  - [x] #11559 (comment)
- Some open questions:
  - [x] #11559 (comment)
  - [x] #11559 (comment)
  - [x] #11559 (comment)

Other code changes are small: some small refactors to make code clearer, less panics, better error messages...

depends on:
- [x] #11560 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
  • Loading branch information
amaury1093 committed Apr 15, 2022
1 parent 9898ac5 commit 53a6f19
Show file tree
Hide file tree
Showing 30 changed files with 968 additions and 657 deletions.
4 changes: 2 additions & 2 deletions api/cosmos/app/v1alpha1/module.pulsar.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

126 changes: 100 additions & 26 deletions api/cosmos/group/v1/events.pulsar.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 53a6f19

Please sign in to comment.