Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for feegrant pruning #10685

Closed
2 of 4 tasks
robert-zaremba opened this issue Dec 6, 2021 · 0 comments · Fixed by #10830
Closed
2 of 4 tasks

Add support for feegrant pruning #10685

robert-zaremba opened this issue Dec 6, 2021 · 0 comments · Fixed by #10830
Assignees
@atheeshp
Labels
C: gas C:x/feegrant

Comments

@robert-zaremba
Copy link
Collaborator

Summary

Similarly to x/authz we should enable feegrant objects auto-prunning using an index (similarly as we move / delete proposals in x/gov).

Ref:

cc: @aleem1314

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba added this to the v0.46 milestone Dec 6, 2021
@atheeshp atheeshp self-assigned this Dec 7, 2021
@atheeshp atheeshp mentioned this issue Dec 13, 2021
Closed
4 tasks
@atheeshp atheeshp mentioned this issue Dec 22, 2021
Merged
19 tasks
@mergify mergify bot closed this as completed in #10830 Feb 8, 2022
mergify bot pushed a commit that referenced this issue Feb 8, 2022
@atheeshp
feat: adds pruning for feegrant (#10830)
786afb3 
Closes: #10685 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atheeshp atheeshp

Labels
C: gas C:x/feegrant
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: adds pruning for feegrant cosmos/cosmos-sdk
2 participants
@robert-zaremba @atheeshp