Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add guideline to adding custom sign mode #11055

Closed
7 tasks done
robert-zaremba opened this issue Jan 28, 2022 · 2 comments · Fixed by #13104
Closed
7 tasks done

Add guideline to adding custom sign mode #11055

robert-zaremba opened this issue Jan 28, 2022 · 2 comments · Fixed by #13104
Assignees
@tac0turtle

Comments

@robert-zaremba
Copy link
Collaborator

robert-zaremba commented Jan 28, 2022 •
edited by tac0turtle

Summary

  • update docs
  • add comment in the proto file
  • add new entrry in proto file if needed

Problem Definition

Proposal

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba mentioned this issue Jan 28, 2022
Closed
13 tasks
@aaronc aaronc mentioned this issue Jan 28, 2022
Merged
19 tasks
mergify bot pushed a commit that referenced this issue Jan 29, 2022
@aaronc
docs: add guidelines for registering new sign modes (#11056)
dd0d712 
## Description

ref #11055



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
@tac0turtle
Copy link
Member

I was thinking about this, and while it is nice we are allowing teams to do this, this means they're launch may be blocked on an sdk release if im not mistaken?

@aaronc
Copy link
Member

aaronc commented Jan 30, 2022 •
edited

Proto files are now released independently in the api module and buf schema registry. Once the tx handler migrates to pulsar they won't be blocked

@tac0turtle tac0turtle mentioned this issue Aug 30, 2022
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tac0turtle tac0turtle

Labels
None yet
Projects
No open projects
Cosmos SDK Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: custom signmodes cosmos/cosmos-sdk
3 participants
@aaronc @robert-zaremba @tac0turtle