Add SafeSub for sdk.Coin
#11603
Assignees
Labels
Comments
That would be a big API breaking change, so I prefer to add SafeSub. It also aligns with sdk.Coins API. |
Yes, Let's add |
|
Agreed. @anilcse you wanna take this on or should I? |
|
I can take up this issue. |
mergify bot
pushed a commit
that referenced
this issue
Apr 14, 2022
## Description Closes: #11603 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Coin.Subpanics on errors, instead returning error (ie, addingSafeSubmethod toCoin) would be helpful for operations inside other modules likex/authzProblem Definition
Currently in staking authz we are using
sdk.Coinforauthorization.MaxTokens.sdk.CoinhasSub(which panics when balance goes to negative) method, but notSafeSub(which returns error when balance goes to negative) method.ref: #11478
Proposal
Either convert the panic in
Submethod to error or addSafeSubmethod for sdk.Coin.For Admin Use
The text was updated successfully, but these errors were encountered: