-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
basecoin relay fixes #134
Comments
Easiest way to work with basecli style keys is to make it a basecli command. Acutally, if you want users (non-full nodes) to run this, it makes sense in basecli. |
You want If it is meant to be run by people without full nodes, then I would suggest this. If it is meant to be run on full-nodes, then I am not sure why it should use basecli stuff? We could have a randomly generated key.json and run full-node if you want. I am happy to make it a client command as well. I just don't like a mix of both, which usually assumes client and server on one machine, which is a dev situation, but not common in the real-world (I think). |
My thinking was it should be in |
|
I need to improve the logging of these processes, but I actually think a local rpc server is the main use of |
I could make a third command, for long running client processes?
|
Okay, after talking with bucky, we will:
|
we'll revisit relay when we get IBC back on new sdk - but this should also be thought about in #324 |
* fix testing and protobuf related issues * remove unnecessary changes in legacy migration tests * remove extraneous comments * add test for minselfdelegation * fix: Ensure that MsgCreateValidator's accompanying delegation is at least the provided MinSelfDelegation (#132) * add check to make sure validator object is only created if min delegation threshold is met * fix check location and use standard error type * fix logic for check * add test for new check * update test comments for better context * add checks for global min self delegation and fix corresponding tests * add migration code * fix migration code tests * fix staking client unit tests * tidy up * Apply suggestions from code review Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * apply changes suggested in review * fixed edge case error * lint++ * lint++ * Update x/staking/keeper/msg_server.go * Update x/staking/keeper/msg_server.go * Update x/staking/keeper/msg_server.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com> Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
The text was updated successfully, but these errors were encountered: