-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(x/authz)!: Use KVStoreService, context.Context and return errors instead of panic #15962
Conversation
…/kvstoresvc-authz
if len(queueItems.MsgTypeUrls) == 0 { | ||
k.setGrantQueueItem(ctx, expiration, granter, grantee, &authz.GrantQueueItem{ | ||
MsgTypeUrls: []string{msgType}, | ||
}) | ||
} else { | ||
queueItems.MsgTypeUrls = append(queueItems.MsgTypeUrls, msgType) | ||
k.setGrantQueueItem(ctx, expiration, granter, grantee, queueItems) | ||
} | ||
|
||
return nil | ||
queueItems.MsgTypeUrls = append(queueItems.MsgTypeUrls, msgType) | ||
return k.setGrantQueueItem(ctx, expiration, granter, grantee, queueItems) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplified this
func (k Keeper) getGrant(ctx sdk.Context, skey []byte) (grant authz.Grant, found bool) { | ||
store := ctx.KVStore(k.storeKey) | ||
bz := store.Get(skey) | ||
func (k Keeper) getGrant(ctx context.Context, skey []byte) (grant authz.Grant, found bool) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to modify this to return also an error? I'm not sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since its internal i think its fine
#15948 contains the fixes for the linter and the simapp v1 tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
…rors instead of panic (cosmos#15962)
…rors instead of panic (cosmos#15962)
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change