-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Upgrade from v0.47.1 -> v0.47.2 causing issues #16027
Comments
thanks for opening the issue, could you link me to your code in order to test out the changes |
im running a testnet and upgraded things with no issue, i tried a few times if i missed something with no luck. I started a testnet with 0.47.1 ran it a few blocks submitted txs then stopped it and upgraded to 0.47.2 and submitted more txs with success. I tested with 0.47.0 then upgrade to 0.47.2 as well with blocks and transactions passing. Could you walk me through what you did here? |
Hi @tac0turtle! Thanks for looking into this. I am starting a fresh paloma testnet with 0.47.2 and seeing these errors. The bootstrapping of the nodes is in an ansible runbook, but I will write up a gist to reproduce this. |
Okay. So this seems to be a setup issue on the Paloma side of our private testnet. @ToasterTheBrave will close. |
I've narrowed down exactly what's causing this. It appears to be a specific set of config around logging when starting up a new testnet. Specifically, I'm seeing that Environment:
Reproduction steps:
Now, if we check the status of simapp, it's not producing blocks. Ex:
|
@alexanderbez Should this be reopened give the above ^? |
@julienrbrt are you able to double check this? |
@julienrbrt and i were unable to reproduce this issue with a variety of configurations. closing this |
What we can do is tagging a v0.47.3-rc.0 for you to try again. |
@julienrbrt I'll test out the new version. In your trials, were you using three nodes? I'm curious what could possibly be different between our example setups. |
@julienrbrt I tested in v0.47.3. This is still a problem. I need more info about how you ran your tests that didn't produce the error so I can give more context if needed. |
@ToasterTheBrave I get same error when upgrade from v0.47.2 to v0.47.3, but seems related to logger change, test pass with cometbft fix. |
I was using in-process nodes with a tweaked Possibly, the new cometbft release resolves your issue when used with v0.47.3: https://github.com/cometbft/cometbft/blob/v0.37.2/CHANGELOG.md#security-fixes |
@julienrbrt Yes indeed, this is fixed for us now with cometbft v0.37.2 🙂 |
Summary of Bug
When upgrading from cosmos-sdk@v0.47.1 to cosmos-sdk@v0.47.2 and starting a new testnet, the testnet fails to start and produce blocks.
The same steps worked previously in cosmos-sdk@v0.47.1. After the upgrade, no blocks are being created and no obvious error messages are being produced. The best I have is the output of the status.
There are occasionally error messages, but they don't seem overly concerning as it's a host trying to add itself to the address book.
Version
v0.47.2
Steps to Reproduce
This was found in palomachain. To reproduce, upgrade cosmos-sdk and cometbtf there and start up a new testnet. I suspect it may be reproducible in other cosmos apps, but I have not tried.
To further show issues, you can try submitting a proposal. We are submitting as such:
And it returns
The text was updated successfully, but these errors were encountered: