Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testutil): adding DefaultContextWithKeys test helper #17216

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

damiannolan
Copy link
Member

Description

  • Adding a new test helper to add flexibility for creating a test context with multiple store keys (kvstore, transientstore, memstore)

Closes: #16998


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@damiannolan damiannolan requested a review from a team as a code owner July 31, 2023 11:29
@github-prbot github-prbot requested review from a team, kocubinski and julienrbrt and removed request for a team July 31, 2023 11:29
@julienrbrt julienrbrt changed the title imp(testing): adding DefaultContextWithKeys test helper feat(testutil): adding DefaultContextWithKeys test helper Jul 31, 2023
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 31, 2023
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@julienrbrt julienrbrt added this pull request to the merge queue Jul 31, 2023
Merged via the queue into main with commit 382de33 Jul 31, 2023
49 of 50 checks passed
@julienrbrt julienrbrt deleted the damian/16998-test-context-with-keys branch July 31, 2023 12:28
mergify bot pushed a commit that referenced this pull request Jul 31, 2023
julienrbrt added a commit that referenced this pull request Jul 31, 2023
…17216) (#17217)

Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add support for test sdk.Context with n store keys, plus mem store keys
2 participants