Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator.Owner -> .Operator // CLI stake to use --validator #1901

Closed
rigelrozanski opened this issue Aug 1, 2018 · 3 comments
Closed

Validator.Owner -> .Operator // CLI stake to use --validator #1901

rigelrozanski opened this issue Aug 1, 2018 · 3 comments
Assignees
@alessio
Labels
C:CLI C:x/staking

Comments

@rigelrozanski
Copy link
Contributor

rigelrozanski commented Aug 1, 2018 •
edited

Ref: #1884

Two action items in this issue:

  • within the code Validator.OwnerAddr to Validator.OperatorAddr
  • within the CLI we should switch the --address-validator to just be --validator
    ALSO need to update the docs around this!
@alexanderbez alexanderbez added this to Suggested in Current Iteration via automation Aug 1, 2018
@rigelrozanski rigelrozanski mentioned this issue Aug 1, 2018
Closed
@cwgoes cwgoes moved this from Suggested to To do in Current Iteration Aug 8, 2018
@alessio
Copy link
Contributor

alessio commented Aug 9, 2018 •
edited

Validator does not seem to have an OwnerAddr field. It has an Owner field. Do we still intend to substitute Validator with Operator? I think so as I don't know how much sense the word "owner" makes in the context of validators.

@alexanderbez
Copy link
Contributor

Yeah I'm pretty sure that is what he means @alessio 👍

@alessio alessio mentioned this issue Aug 9, 2018
Merged
@alexanderbez alexanderbez removed this from To do in Current Iteration Aug 10, 2018
rigelrozanski pushed a commit that referenced this issue Aug 16, 2018
@alessio @rigelrozanski
Merge PR #1950: Validator.Owner -> .Operator
187bc19 
* Rename --address-validator flag to --validator

See #1901

* Update PENDING.md

* Rename Validator.Owner -> Validator.Operator

See #1901
@alessio
Copy link
Contributor

alessio commented Aug 17, 2018

Fixed in #1950

@alessio alessio closed this as completed Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alessio alessio

Labels
C:CLI C:x/staking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alessio @alexanderbez @rigelrozanski