Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GO111MODULE=on to environment. #4042

Merged
merged 3 commits into from
Apr 4, 2019
Merged

Add GO111MODULE=on to environment. #4042

merged 3 commits into from
Apr 4, 2019

Conversation

yangyanqing
Copy link
Contributor

@yangyanqing yangyanqing commented Apr 4, 2019

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@yangyanqing yangyanqing changed the title Add GO111MODULE=on to environment. R4R: Add GO111MODULE=on to environment. Apr 4, 2019
@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #4042 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4042      +/-   ##
===========================================
- Coverage    60.01%   59.99%   -0.02%     
===========================================
  Files          212      212              
  Lines        15107    15107              
===========================================
- Hits          9066     9064       -2     
- Misses        5420     5422       +2     
  Partials       621      621

@alexanderbez alexanderbez changed the title R4R: Add GO111MODULE=on to environment. Add GO111MODULE=on to environment. Apr 4, 2019
Co-Authored-By: yangyanqing <f.yang@hashgard.com>
@fedekunze fedekunze requested a review from alessio April 4, 2019 10:09
@alessio alessio merged commit 055d219 into cosmos:develop Apr 4, 2019
@yangyanqing yangyanqing deleted the frank/add-go-111-module-on-to-env branch April 4, 2019 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants