Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo, url error and outdated command description of doc clients. #4123

Merged
merged 2 commits into from
Apr 15, 2019
Merged

Fix typo, url error and outdated command description of doc clients. #4123

merged 2 commits into from
Apr 15, 2019

Conversation

yangyanqing
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

Merging #4123 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #4123   +/-   ##
========================================
  Coverage    60.08%   60.08%           
========================================
  Files          211      211           
  Lines        15134    15134           
========================================
  Hits          9093     9093           
  Misses        5419     5419           
  Partials       622      622

1 similar comment
@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

Merging #4123 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #4123   +/-   ##
========================================
  Coverage    60.08%   60.08%           
========================================
  Files          211      211           
  Lines        15134    15134           
========================================
  Hits          9093     9093           
  Misses        5419     5419           
  Partials       622      622

@alexanderbez alexanderbez merged commit dfe58f8 into cosmos:develop Apr 15, 2019
@yangyanqing yangyanqing deleted the frank/fix-client-doc branch April 15, 2019 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants