Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cd tools; make check should fail if go version < 1.9 #463

Closed
jaekwon opened this issue Feb 14, 2018 · 2 comments
Closed

cd tools; make check should fail if go version < 1.9 #463

jaekwon opened this issue Feb 14, 2018 · 2 comments
Assignees
@zramsay

Comments

@jaekwon
Copy link
Contributor

jaekwon commented Feb 14, 2018

No description provided.

@jaekwon jaekwon changed the title make check should fail if go version < 1.9 cd tools; make check should fail if go version < 1.9 Feb 14, 2018
@zramsay
Copy link
Contributor

zramsay commented Mar 6, 2018

we should implement this in all repos. I tried a few different ways and they were all ugly, not sure the best way. Ideally, we'd have a min-versions.json in aib-data for minimum versions, that can be checked against what a user has installed.

@zramsay zramsay mentioned this issue Mar 9, 2018
Closed
@zramsay
Copy link
Contributor

zramsay commented Mar 9, 2018

tendermint/coding#56

@zramsay zramsay closed this as completed Mar 9, 2018
ParthDesai pushed a commit to ChorusOne/cosmos-sdk that referenced this issue Apr 19, 2021
@cwgoes
Remove requirement to use "bank" port (closes cosmos#463)
6280b53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zramsay zramsay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaekwon @zramsay