CLI tx commands should generate service Msgs

[amaury1093]

Summary of Bug

There's currently no way to create transactions that contain ADR-031 service Msgs. At the very least, CLI tx commands should output txs with service Msgs.

x/authz can only exec service Msgs, so is blocked on this.

Version

v0.40.0

Proposal

As discussed internally at Regen, we can outline the following plan:

• For 0.41, create a temporary struct ServiceMsgClientConn which implements grpc.ClientConn. This struct actually already exists, but is only used for tests. The idea is to:

  • make this struct public, maybe in types/msgservice
  • make all CLI commands use this struct (so that the generated txs use service msgs).

• For 0.42, try to pull Custom protobuf service code generator #8270 in. Once codegen is in, this temporary ServiceMsgClientConn could be removed, and service Msgs could then be created using TxBuilder (Add ClientConn to TxBuilder to support ADR 031 #7541).

Notes

• An additional idea would be to add a flag --service-msg (true by default) to generate service Msgs or proto Msgs. This might still allow generating amino Msgs.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[aaronc]

I'm not sure why we'd postpone #8270. I did most of the preparatory work already. Delaying it will just mean we have to refactor CLI methods twice right?

[amaury1093]

I was under the impression we marked #8270 as 0.42, happy to revisit that in our next grooming call.

Was also hoping to get both x/authz and x/feegrant merged asap, I believe they will get postponed a week or two if we wait for #8270.

[aaronc]

Well it's just about tradeoffs. I wouldn't block authz and fee grant getting merged in. But if we're refactoring all tx cli commands we might as well do that once the right way. That refactoring is separate from the basic authz implementation as I understand it.

[amaury1093]

That refactoring is separate from the basic authz implementation as I understand it.

IMO the x/authz PR looks good overall, but what feels weird to me before approving are the two following points:

• it introduces a new ServiceMsgClientConn, as a helper (there's one already in x/bank)
• the CLI doesn't work: implement x/authz module #7629 (comment)

How about for now:

• put ServiceMsgClientConn somewhere better than simapp/helper (e.g. types/msgservice as proposed)
• put a TODO somewhere in x/authz to say that it doesn't work
• and we can close this issue and focus on Custom protobuf service code generator #8270 for 0.41
  ?