Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBC: persist counterpart channel before OnChanOpenAck #8334

Closed
4 tasks
alpe opened this issue Jan 14, 2021 · 1 comment · Fixed by #8404
Closed
4 tasks

IBC: persist counterpart channel before OnChanOpenAck #8334

alpe opened this issue Jan 14, 2021 · 1 comment · Fixed by #8404
Assignees

Comments

@alpe
Copy link
Contributor

alpe commented Jan 14, 2021

Summary

Counterparty.ChannelID not available in OnChanOpenAck callback implementation.

Problem Definition

In a previous version the Counterparty.ChannelID was available for an OnChanOpenAck callback implementation (read via channelKeeper.GetChannel(). Now the the channelID is empty.
The data is available at this stage but persisted only some lines after the callback call.

Proposal

It would be helpful if the channel data could be stored first so that the callback implementation could access it.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@cosmos cosmos deleted a comment Jan 14, 2021
@cosmos cosmos deleted a comment Jan 14, 2021
@cosmos cosmos deleted a comment Jan 14, 2021
@cosmos cosmos deleted a comment Jan 14, 2021
@colin-axner
Copy link
Contributor

colin-axner commented Jan 15, 2021

The fix: reorder handler to execute core handling first and then application callback (as state above).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants