Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ABCI Range Query #871

Closed
rigelrozanski opened this issue Apr 16, 2018 · 8 comments · Fixed by #969
Closed

ABCI Range Query #871

rigelrozanski opened this issue Apr 16, 2018 · 8 comments · Fixed by #969
Labels
C:ABCI
Milestone
v0.38.0

Comments

@rigelrozanski
Copy link
Contributor

We need a way to query a range from a store
Right now we are only able to query from a key:
https://github.com/cosmos/cosmos-sdk/blob/develop/client/core/core.go#L45
This was referenced May 7, 2018
Closed
Merged
@jackzampolin
Copy link
Member

jackzampolin commented Oct 12, 2018 •
edited
Loading

Should this be an issue on Tendermint? and is this still #prelaunch?

@rigelrozanski
Copy link
Contributor Author

I think we might need this lite client proofs - not 100% certain - either way we want this feature

@jackzampolin
Copy link
Member

Range queries returning lite client proofs. This sounds like an issue for Tendermint right? I'm guessing this is still a requirement.

@rigelrozanski
Copy link
Contributor Author

in a big way yes it is

@jackzampolin jackzampolin mentioned this issue May 28, 2019
Closed
@alexanderbez
Copy link
Contributor

alexanderbez commented May 29, 2019 •
edited
Loading

Errrrr, this is 100% doable right now completely in the SDK. As you've stated, yes we support key queries with proofs. We can easily extend baseapp to allow for range queries (with proofs). The IAVL store would just call GetVersionedRangeWithProof|GetRangeWithProof.

I can pick this up.

@alexanderbez alexanderbez assigned alexanderbez and unassigned mossid May 29, 2019
@jackzampolin
Copy link
Member

Any update here @alexanderbez? Is this something that is going to require the lite client spec from TM?

@jackzampolin jackzampolin added this to the v0.38.0 milestone Sep 5, 2019
@alexanderbez
Copy link
Contributor

@jackzampolin just an issue we need to prioritize/story-point. There is zero dependency on TM from what I can remember.

@alexanderbez alexanderbez mentioned this issue Oct 12, 2019
Closed
4 tasks
@gelinger777 gelinger777 mentioned this issue Jun 6, 2020
Closed
@alexanderbez alexanderbez removed the core label Jul 6, 2020
@alexanderbez alexanderbez removed their assignment Mar 21, 2022
@tac0turtle
Copy link
Member

being worked on with the schema package

chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this issue Mar 1, 2024
@faddat @alexanderbez
fix: add version to buf.yaml (cosmos#923)
6bc46ed 
* fix: add version to buf.yaml

closes cosmos#871

* Update buf.yaml

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:ABCI
Projects
None yet
Milestone
v0.38.0
Development

Successfully merging a pull request may close this issue.

subspace queries + few more staking queries cosmos/cosmos-sdk
7 participants
@ebuchman @alexanderbez @jackzampolin @mossid @rigelrozanski @tac0turtle @fedekunze