Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging: add more info to crisis logs #8785

Merged
merged 4 commits into from
Mar 4, 2021
Merged

logging: add more info to crisis logs #8785

merged 4 commits into from
Mar 4, 2021

Conversation

tac0turtle
Copy link
Member

Description

Example:

2:00PM INF asserting crisis invariants inv=0/11 module=x/crisis name=distribution/nonnegative-outstanding
2:00PM INF asserting crisis invariants inv=1/11 module=x/crisis name=distribution/can-withdraw

closes: #8621

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@tac0turtle tac0turtle added A:automerge Automatically merge PR once all prerequisites pass. backport/0.41.x (Stargate) labels Mar 4, 2021
@tac0turtle tac0turtle self-assigned this Mar 4, 2021
amaury1093
amaury1093 approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@amaury1093 amaury1093 removed the A:automerge Automatically merge PR once all prerequisites pass. label Mar 4, 2021
@amaury1093
Copy link
Contributor

I removed automerge for now, let's merge #8784 first to save us some manual work

@codecov
Copy link

codecov bot commented Mar 4, 2021 •
edited

Codecov Report

Merging #8785 (aa249bf) into master (da064e1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8785   +/-   ##
=======================================
  Coverage   59.34%   59.34%           
=======================================
  Files         563      563           
  Lines       31251    31251           
=======================================
  Hits        18545    18545           
  Misses      10551    10551           
  Partials     2155     2155
Impacted Files Coverage Δ
x/crisis/keeper/keeper.go 86.20% <100.00%> (ø)

@alessio alessio added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 4, 2021
@mergify mergify bot merged commit 82aedba into master Mar 4, 2021
@mergify mergify bot deleted the 8621/crisis branch March 4, 2021 20:40
@alessio
Copy link
Contributor

alessio commented Mar 4, 2021

@Mergifyio backport release/v0.42.x

mergify bot pushed a commit that referenced this pull request Mar 4, 2021
@tac0turtle
logging (#8785)
efc2e46 
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 82aedba)
@mergify mergify bot mentioned this pull request Mar 4, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented Mar 4, 2021

Command backport release/v0.42.x: success

Backports have been created

alessio pushed a commit that referenced this pull request Mar 4, 2021
@mergify @tac0turtle
logging (#8785) (#8791)
c9f15de 
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 82aedba)

Co-authored-by: Marko <marbar3778@yahoo.com>
This was referenced Mar 11, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio alessio alessio approved these changes

@robert-zaremba robert-zaremba robert-zaremba approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

@jgimeno jgimeno jgimeno approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@anilcse anilcse Awaiting requested review from anilcse

@ValarDragon ValarDragon Awaiting requested review from ValarDragon

Assignees

@tac0turtle tac0turtle

Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a name to crisis invariants, and print these in logs
5 participants
@tac0turtle @amaury1093 @alessio @robert-zaremba @jgimeno