feat: expose HasMetadata on bank Keeper

[fedekunze]

Add HasMetaData to bank keeper API.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct docs: prefix in the PR title
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the documentation writing guidelines
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct docs: prefix in the PR title
• confirmed all author checklist items have been addressed
• confirmed that this PR only changes documentation
• reviewed content for consistency
• reviewed content for thoroughness
• reviewed content for spelling and grammar
• tested instructions (if applicable)

[orijbot]

Visit https://dashboard.github.orijtech.com?back=0&pr=10134&remote=false&repo=cosmos%2Fcosmos-sdk to see benchmark details.

[codecov]

Codecov Report

Merging #10134 (06bd395) into master (6fc79b1) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 06bd395 differs from pull request most recent head 26e12bf. Consider uploading reports for the commit 26e12bf to get more accurate results

@@            Coverage Diff             @@
##           master   #10134      +/-   ##
==========================================
- Coverage   63.62%   63.61%   -0.02%     
==========================================
  Files         573      572       -1     
  Lines       53606    53575      -31     
==========================================
- Hits        34109    34081      -28     
+ Misses      17550    17548       -2     
+ Partials     1947     1946       -1     

Impacted Files	Coverage Δ
x/bank/keeper/keeper.go	72.75% <100.00%> (+0.38%)	⬆️
x/auth/tx/mode_handler.go	76.47% <0.00%> (-2.48%)	⬇️
client/tx/tx.go	40.00% <0.00%> (-1.58%)	⬇️
x/auth/tx/direct_aux.go

[fedekunze]

why is the linter suddenly failing?

[alexanderbez]

ACK, but you don't really need this API. You can also do:

if _, ok := k.bankKeeper.GetDenomMetaData(ctx, baseDenom); !ok {
  // ...
}

[fedekunze]

true @alexanderbez, although store.Has is cheaper than store.Get in terms of gas if you only want to check for the existence of a metadata

[alexanderbez]

Fair point!